Skip to content

Implement profile page #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 3, 2021
Merged

Implement profile page #673

merged 6 commits into from
Sep 3, 2021

Conversation

@joedixon
Copy link
Contributor

@joedixon joedixon commented Aug 25, 2021 •
edited
Loading

Screenshot 2021-08-27 at 16 24 31

Screenshot 2021-08-27 at 16 24 14

Screenshot 2021-08-27 at 16 27 28

Screenshot 2021-08-27 at 16 23 56

@joedixon joedixon changed the title Implement article detail page Implement profile page Aug 25, 2021
@joedixon joedixon force-pushed the implement-profile-page branch 2 times, most recently from 3e77a0d to 191873f Compare August 27, 2021 15:24
@joedixon joedixon force-pushed the implement-profile-page branch from 191873f to fbb1380 Compare August 27, 2021 15:26
@joedixon joedixon marked this pull request as ready for review August 27, 2021 22:01
@joedixon joedixon requested a review from driesvints August 27, 2021 22:01
driesvints
driesvints requested changes Aug 28, 2021
View reviewed changes
Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do something fun for these places where there's no content?

Screen Shot 2021-08-28 at 11 51 21

Something like...

Screen Shot 2021-08-28 at 11 52 59

I think there are some free artwork platforms that we could consult.

I also realized that the list of replies on the user profile don't make much sense atm. You can't see to which thread they belong. I think we need to slightly redesign these. They also shouldn't be interactive (no clickable likes, solution chosing, no dropdown menu). Just clickable so you can link to them in a thread.

Screen Shot 2021-08-28 at 12 01 21

@joedixon
Copy link
Contributor Author

joedixon commented Sep 1, 2021

Maybe we can do something fun for these places where there's no content?

I think this is a nice idea, but are you happy if we add it as an issue for now while we find some artwork we like?

@joedixon
Copy link
Contributor Author

joedixon commented Sep 1, 2021 •
edited
Loading

New reply component for the profile page.

Screenshot 2021-09-01 at 20 07 36

@joedixon joedixon requested a review from driesvints September 1, 2021 19:18
@driesvints
Copy link
Member

driesvints commented Sep 2, 2021

@joedixon for the empty states. Can you maybe use the "simple" component from https://tailwindui.com/components/application-ui/feedback/empty-states ?

@joedixon
Copy link
Contributor Author

joedixon commented Sep 2, 2021

Screenshot 2021-09-02 at 19 56 32

Screenshot 2021-09-02 at 19 56 24

@joedixon joedixon merged commit ea6aac2 into main Sep 3, 2021
@joedixon joedixon deleted the implement-profile-page branch September 3, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@driesvints driesvints Awaiting requested review from driesvints

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joedixon @driesvints